Re: Fix doc: explanation of how postgres works when OOM killer is invoked - Mailing list pgsql-hackers

From Takeshi Ideriha
Subject Re: Fix doc: explanation of how postgres works when OOM killer is invoked
Date
Msg-id 3afa7212-fefe-45d2-b40a-62ee5d5254bf@gmail.com
Whole thread
In response to Re: Fix doc: explanation of how postgres works when OOM killer is invoked  (Manu <manuelreyesbravo@gmail.com>)
Responses Re: Fix doc: explanation of how postgres works when OOM killer is invoked
List pgsql-hackers
Hi Manu

Thank you for the comments.
I registered this to CF https://commitfest.postgresql.org/patch/7407/ .

> I looked into this as well, and the patch matches what I see.  

I checked the almost same thing as you did. Thank you for the confirmation.

> 
> Two small things:
> 
> - With restart_after_crash off, the server does not stay down passively:
>   it logs 'shutting down because "restart_after_crash" is off' and shuts
>   the whole cluster down, so a manual restart is needed.  The patch gives
>   the "on" case; it might be worth saying what "off" does too.
> 
> - A little further down, this same section recommends protecting the
>   postmaster with a low oom_score_adj so the OOM killer picks a child.
>   With that in place the victim is a backend -- your "another server
>   process" case -- while "the postmaster is terminated" is mostly what
>   happens without that protection.  Relating the two might help the
>   reader, though it may be more than this fix intends.

Both of the points make sense. I added them in v2 patch.

Regards,
Takeshi Ideriha
Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Incorrect CONTEXT reported for errors from parallel apply worker in logical replication
Next
From: Manu
Date:
Subject: Re: Fix doc: explanation of how postgres works when OOM killer is invoked