[HACKERS] Patch for psql.c - Mailing list pgsql-hackers

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

- ---2133963750-1257526183-865259446=:24416
Content-Type: TEXT/PLAIN; charset=US-ASCII

Gets rid of memory leaks that occur during regression tests (well, except
for a leak in SGI's NIS handling stuff :) )...

If someone would look over this and verify it; I want to be sure that
after a PQexec, no matter what the result (barring NULL), the result
should be cleared;  I pulled individual PQclears out of a case statement
and dropped them at the end (lines 579-595) so that the PQclear will be
hit no matter which case is hit.  Still getting acquainted :)

- -Tymm

- ---2133963750-1257526183-865259446=:24416
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=psql_patch
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.SGI.3.96.970602085046.24416O@lucid.coe.missouri.edu>
Content-Description:

KioqIC9kZXZlbC90ZW1wL3Bvc3RncmVzL3NyYy9iaW4vcHNxbC9wc3FsLmMJ
U3VuIEp1biAgMSAyMzowMToyNyAxOTk3DQotLS0gLi9wc3FsLmMJTW9uIEp1
biAgMiAwNzoyNjoxMSAxOTk3DQoqKioqKioqKioqKioqKioNCioqKiA1MDYs
NTEzICoqKioNCiAgICAgIGxpbmUgPSBtYWxsb2MoTUFYX1FVRVJZX0JVRkZF
UiArIDEpOw0KICANCiAgICAgIC8qIHJlYWQgdXAgdG8gTUFYX1FVRVJZX0JV
RkZFUiBjaGFyYWN0ZXJzICovDQohICAgICBpZiAoZmdldHMobGluZSwgTUFY
X1FVRVJZX0JVRkZFUiwgc291cmNlKSA9PSBOVUxMKQ0KICAJcmV0dXJuIE5V
TEw7DQogIA0KICAgICAgbGluZVtNQVhfUVVFUllfQlVGRkVSIC0gMV0gPSAn
XDAnOw0KICAgICAgbGVuID0gc3RybGVuKGxpbmUpOw0KLS0tIDUwNiw1MTUg
LS0tLQ0KICAgICAgbGluZSA9IG1hbGxvYyhNQVhfUVVFUllfQlVGRkVSICsg
MSk7DQogIA0KICAgICAgLyogcmVhZCB1cCB0byBNQVhfUVVFUllfQlVGRkVS
IGNoYXJhY3RlcnMgKi8NCiEgICAgIGlmIChmZ2V0cyhsaW5lLCBNQVhfUVVF
UllfQlVGRkVSLCBzb3VyY2UpID09IE5VTEwpIHsNCiEgCWZyZWUobGluZSk7
DQogIAlyZXR1cm4gTlVMTDsNCisgICAgIH0NCiAgDQogICAgICBsaW5lW01B
WF9RVUVSWV9CVUZGRVIgLSAxXSA9ICdcMCc7DQogICAgICBsZW4gPSBzdHJs
ZW4obGluZSk7DQoqKioqKioqKioqKioqKioNCioqKiA1NDMsNTQ5ICoqKioN
CiAgCQkiKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KipcbiIpOw0KICAJZmZsdXNoKHN0ZG91dCk7DQogIAlwcmludGYoIlxucHJl
c3MgcmV0dXJuIHRvIGNvbnRpbnVlIC4uXG4iKTsNCiEgCWdldHNfZnJvbUZp
bGUoIiIsIHN0ZGluKTsNCiAgICAgIH0NCiAgICAgIHJlc3VsdHMgPSBQUWV4
ZWMoc2V0dGluZ3MtPmRiLCBxdWVyeSk7DQogICAgICBpZiAocmVzdWx0cyA9
PSBOVUxMKSB7DQotLS0gNTQ1LDU1MSAtLS0tDQogIAkJIioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqXG4iKTsNCiAgCWZmbHVz
aChzdGRvdXQpOw0KICAJcHJpbnRmKCJcbnByZXNzIHJldHVybiB0byBjb250
aW51ZSAuLlxuIik7DQohIAlmcmVlKGdldHNfZnJvbUZpbGUoIiIsIHN0ZGlu
KSk7DQogICAgICB9DQogICAgICByZXN1bHRzID0gUFFleGVjKHNldHRpbmdz
LT5kYiwgcXVlcnkpOw0KICAgICAgaWYgKHJlc3VsdHMgPT0gTlVMTCkgew0K
KioqKioqKioqKioqKioqDQoqKiogNTc5LDU5NSAqKioqDQogIAkJCSYoc2V0
dGluZ3MtPm9wdCkpOw0KICAJCWZmbHVzaChzZXR0aW5ncy0+cXVlcnlGb3V0
KTsNCiAgCSAgICB9DQotIAkgICAgUFFjbGVhcihyZXN1bHRzKTsNCiAgCSAg
ICBicmVhazsNCiAgCWNhc2UgUEdSRVNfRU1QVFlfUVVFUlk6DQogIAkgICAg
KnN1Y2Nlc3NfcCA9IHRydWU7DQotIAkgICAgUFFjbGVhcihyZXN1bHRzKTsN
CiAgCSAgICBicmVhazsNCiAgCWNhc2UgUEdSRVNfQ09NTUFORF9PSzoNCiAg
CSAgICAqc3VjY2Vzc19wID0gdHJ1ZTsNCiAgCSAgICBpZiAoIXNldHRpbmdz
LT5xdWlldCkNCiAgCQlmcHJpbnRmKHN0ZG91dCwgIiVzXG4iLCBQUWNtZFN0
YXR1cyhyZXN1bHRzKSk7DQotIAkgICAgUFFjbGVhcihyZXN1bHRzKTsNCiAg
CSAgICBicmVhazsNCiAgCWNhc2UgUEdSRVNfQ09QWV9PVVQ6DQogIAkgICAg
KnN1Y2Nlc3NfcCA9IHRydWU7DQotLS0gNTgxLDU5NCAtLS0tDQoqKioqKioq
KioqKioqKioNCioqKiA2MDEsNjA3ICoqKioNCiAgDQogIAkJaGFuZGxlQ29w
eU91dChyZXN1bHRzLCBzZXR0aW5ncy0+cXVpZXQsIHN0ZG91dCk7DQogIAkg
ICAgfQ0KLSAJICAgIFBRY2xlYXIocmVzdWx0cyk7DQogIAkgICAgYnJlYWs7
DQogIAljYXNlIFBHUkVTX0NPUFlfSU46DQogIAkgICAgKnN1Y2Nlc3NfcCA9
IHRydWU7DQotLS0gNjAwLDYwNSAtLS0tDQoqKioqKioqKioqKioqKioNCioq
KiA2MDksNjE1ICoqKioNCiAgCQloYW5kbGVDb3B5SW4ocmVzdWx0cywgZmFs
c2UsIGNvcHlzdHJlYW0pOw0KICAJICAgIGVsc2UNCiAgCQloYW5kbGVDb3B5
SW4ocmVzdWx0cywgIXNldHRpbmdzLT5xdWlldCwgc3RkaW4pOw0KLSAJICAg
IFBRY2xlYXIocmVzdWx0cyk7DQogIAkgICAgYnJlYWs7DQogIAljYXNlIFBH
UkVTX05PTkZBVEFMX0VSUk9SOg0KICAJY2FzZSBQR1JFU19GQVRBTF9FUlJP
UjoNCi0tLSA2MDcsNjEyIC0tLS0NCioqKioqKioqKioqKioqKg0KKioqIDYx
OCw2MjMgKioqKg0KLS0tIDYxNSw2MjIgLS0tLQ0KICAJICAgIGZwcmludGYo
c3RkZXJyLCAiJXMiLCBQUWVycm9yTWVzc2FnZShzZXR0aW5ncy0+ZGIpKTsN
CiAgCSAgICBicmVhazsNCiAgCX0NCisgCQ0KKyAJUFFjbGVhcihyZXN1bHRz
KTsNCiAgDQogIAlpZiAoUFFzdGF0dXMoc2V0dGluZ3MtPmRiKSA9PSBDT05O
RUNUSU9OX0JBRCkgew0KICAJICAgIGZwcmludGYoc3RkZXJyLA0KKioqKioq
KioqKioqKioqDQoqKiogMTYyOSwxNjM0ICoqKioNCi0tLSAxNjI4LDE2MzQg
LS0tLQ0KICAJICAgIHFmaWxlbmFtZSA9IG9wdGFyZzsNCiAgCSAgICBicmVh
azsNCiAgCWNhc2UgJ0YnOg0KKyAJICAgIGZyZWUoc2V0dGluZ3Mub3B0LmZp
ZWxkU2VwKTsNCiAgCSAgICBzZXR0aW5ncy5vcHQuZmllbGRTZXAgPSBvcHRh
cmc7DQogIAkgICAgYnJlYWs7DQogIAljYXNlICdsJzoNCioqKioqKioqKioq
KioqKg0KKioqIDE3NDEsMTc0NyAqKioqDQogICAgICB9DQogIA0KICAgICAg
UFFmaW5pc2goc2V0dGluZ3MuZGIpOw0KISANCiAgICAgIHJldHVybiAhc3Vj
Y2Vzc1Jlc3VsdDsNCiAgfQ0KICANCi0tLSAxNzQxLDE3NTMgLS0tLQ0KICAg
ICAgfQ0KICANCiAgICAgIFBRZmluaXNoKHNldHRpbmdzLmRiKTsNCiEgICAg
IA0KISAgICAgLyoNCiEgICAgICAqIGdldCBwdXJpZnkgdG8gc2h1dCB1cC4N
CiEgICAgICAqLw0KISAgICAgaWYgKHNldHRpbmdzLm9wdC5maWVsZFNlcCkN
CiEgCWZyZWUoc2V0dGluZ3Mub3B0LmZpZWxkU2VwKTsNCiEgCQ0KICAgICAg
cmV0dXJuICFzdWNjZXNzUmVzdWx0Ow0KICB9DQogIA0K
- ---2133963750-1257526183-865259446=:24416--

------------------------------