Re: [BUGS] Autocomplete on Postgres7.4beta5 not working? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?
Date
Msg-id 3F9EEC0C.8080103@dunslane.net
Whole thread Raw
In response to Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?  (Greg Stark <gsstark@mit.edu>)
Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

>Gaetano Mendola <mendola@bigfoot.com> writes:
>  
>
>>I'm esperiencing problem with the <TAB> autocomplete on
>>postgres 7.4beta5:
>>    
>>
>
>  
>
>>#select * from pg_l<TAB><TAB>
>>and no suggestions out.
>>    
>>
>
>This appears to have been a deliberate change:
>
>2003-03-27 11:45  momjian
>
>    * src/bin/psql/tab-complete.c: Attached are two patches for psql's
>    tab-completion.c.
>        [snip]
>
>    Note that tables, indexes, views and sequences relations in the
>    'pg_catalog' namespace are excluded even though they are in the
>    current search path. I found not doing this produced annoying
>    behaviour when expanding names beginning with 'p'. People who work
>    with system tables a lot may not like this though; I can look for
>    another solution if necessary.
>    
>    Ian Barwick
>
>AFAICT there was no discussion about this issue when the patch was
>proposed and applied.  But now that the point is raised I have to say
>that I don't like this change.  I don't think system catalogs should be
>excluded from tab completion.  They never were before 7.4, and I have
>not seen anyone complaining about that, other than Ian.
>
>Comments anyone?
>  
>

Might be better to:

1. make it a settable option

and/or

2. include catalog objects in expansion iff we are expanding "pg_" + 
optional suffix (probably best of both worlds).

I rarely use completion in this way so I could be an unrepresentative 
user, though :-)

cheers

andrew




pgsql-hackers by date:

Previous
From: Ian Barwick
Date:
Subject: Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?
Next
From: Alvaro Herrera Munoz
Date:
Subject: Re: [BUGS] Autocomplete on Postgres7.4beta5 not working?