Re: EditGrid options - Mailing list pgadmin-hackers

Dave Page wrote:

>It's rumoured that Andreas Pflug once said:
>
>
>>Dave Page wrote:
>>
>>
>>
>>>That's an easy fix. For example, Outlook puts a 'Filter Applied' label
>>>at the top of the listbox.>
>>>
>>>
>>>
>>>
>>Could be, I'm not sure if we can have a 3rd line in the header control.
>>
>>
>>
>>
>It could easily be just above the control, only affecting the position of
>the control when required, or there permanently, in a shaded colour to
>make it look intended when there is no text there.>
>
>
This would be the natural position to sort and filter too. Without
buttons...
If filtering is somehow integrated in each column, this works as kind of
wizard (the freetext form will provoke problems with column name
quoting, which isn't needed anywhere throughout pgAdmin but here).

BTW, filter validation is fine, but this is another message box, even if
ok, giving a beep each time! Can't we handle this silently, in the
status line? We don't need a window that forces the user's attention to
the problem, he's already aware that there might be one.
And this is the only dialog that has a single non-standard sized button
on the left side...


>>>What you are asking for is a second
>>>view data menu option that doesn't auto query, however that would be
>>>ugly as well. As it stands now, you are no worse off than in 1.0.0.
>>>With an auto query toggle button, those that know they are working on
>>>large data sets can turn it off in advance,
>>>
>>>
>>>
>>How that? In global options? That's nasty.
>>
>>
>>
>No, like I originally suggested, a toggle button in the button bar who's
>state is remembered between invocations. Similar to the auto-update button
>in MS query, or XRCed to name just a couple.>
>
>
Please don't mention MS query, I've been suffering from this tool too
often...

>>Second menu is easier to use.
>>
>>
>>
>What would you have:
>
>View Data
>View Data (but not immediately)
>
>;-) Seriously though, I'm happy to entertain that idea if you can think of
>a way it doesn't sound ridiculous.>
>
>
View Data
View Data after the user has entered a filter and pushed the update button
:o)

seriously: View filtered Data.
Instead of showing a collapsed dialog, with data readily queried, the
expanded view without data is shown

>>>That's certainly more palatable than a notebook, but I'm still not
>>>convinced it's the best way.>
>>>
>>>
>>>
>>So be positive, and make proposals.
>>
>>
>>
>I did - I committed it to CVS. That seems like the natural way to do it to
>me, which is why I implemented it that way. I'm happy to be corrected if
>I'm wrong, or consider other opinions, but so far you have not convinced
>me that my original design is not the best way.
>That's why I asked for other opinions at the end of my last message - I'll
>go with the majority opinion (and will happily do any required recoding).
>Come on people - don't be shy!!
>
>
>>>>How about abbrevations if it really doesn't fit? This looks *ugly*!
>>>>
>>>>
>>>>
>>>OK, now I get it. Clearly you had too much beer last night :-). How can
>>>you possibly say that abbreviated text will look better than buttons
>>>that are 25% or so wider than normal, particularly when those button
>>>are uniform sized in their own group, fit into the space they are
>>>positioned in properly, and are visually seperate from any other
>>>buttons of different size?
>>>
>>>
>>>
>>So get rid of that buttons.
>>
>>
>>
>And replace them with what? A neural interface? ;-)
>
>
>>>If you are going to try to enforce a style guide without consultation
>>>with the rest of us first, at least make sure that you specify objects
>>>big enough for perfectly reasonable captions.>
>>>
>>>
>>>
>>>
>>There's some aesthetical limit on button sizes. IMHO this limit is
>>nearly reached. Standard size for MS buttons is (46,15d), btw.
>>
>>
>>
>Yes, but they enlarge as required. Right-click, Properties, and then click
>the desktop tab on UK Windows XP (and probably others) and you'll see a
>'Customise Desktop' button which is much bigger, but doesn't look wrong
>because it's logically seperate from other buttons of standard size.>
>
>

>>I'm counting 5 lines... CreateListColumns takes two strings as
>>left/right header, and the size of the left header in DlgUnits, do you
>>need less?
>>
>>
>>
>OK, 5. I'm not near the code right now. It still does a lot less but I'll
>change it if you insist.
>
>
It really does exactly the same. Actually, I was quite happy to have
this method, changing from pixels to DlgUnits was easy.

Regards,
Andreas