Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race
Date
Msg-id 3E582AB7-AE4B-45A0-8409-F42C81FD1F3E@yandex-team.ru
Whole thread
In response to Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

> On 7 May 2026, at 03:54, Michael Paquier <michael@paquier.xyz> wrote:
>
> +#include "../injection_points/injection_point_condition.h"
>
> Hmm.  I would not see a problem in just moving all that to the module
> injection_points instead, and keep it there, including your TAP test.
> Noah has done something similar for its removable_cutoff() business,
> and we are living well with it.  One issue with the structure you are
> proposing is that I suspect that it makes some installcheck scenarios
> more iffy to deal with.  More callbacks in the test module is fine.

Thanks, Michael!

Done so. I still keep Vlad's injection_point_condition.h though.
It seems useful. But no more Meson\Makefile changes, and new sql stuff lives
now near removable_cutoff() SQL.

Vlad, there are 2 patches in the patchset again :)

Now we need an expert in ProcKill(). I also will review the patchset in more detail,
but, perhaps, after pgconf.dev.


Best regards, Andrey Borodin.


Attachment

pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: "Euler Taveira"
Date:
Subject: Re: Include schema-qualified names in publication error messages.