Re: Proposal: Make cfbot fail on patches not created by "git format-patch" - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date
Msg-id 3DEAFBC1-2F52-44E5-A56D-021D97F673D9@yesql.se
Whole thread Raw
In response to Proposal: Make cfbot fail on patches not created by "git format-patch"  (Jelte Fennema-Nio <me@jeltef.nl>)
List pgsql-hackers
> On 16 May 2025, at 11:52, Jelte Fennema-Nio <me@jeltef.nl> wrote:

> Does anyone have strong opposition to this? To be clear, it means we don't run CI on patches created by  piping "git
diff"to a file anymore, as a way to nudge submitters into providing useful commit messages. 

Disclaimer: I wasn't in the session (due to conflicting interesting sessions)
so I might be raising points/questions already answered.

Is this really lowering the bar for new contributors?  I've always held "be
liberal in what you accept" as a gold standard for projects I'm involved in, to
remove barriers to entry.  Good commit messages are obviously very important,
but having your patch rejected (yes, I know, failing to apply) might not be
strongest motivator for achieving this.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: C extension compilation failed while using PG 17.2 on mac m1
Next
From: Alena Rybakina
Date:
Subject: Re: wrong query results on bf leafhopper