Re: new heapcheck contrib module - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: new heapcheck contrib module
Date
Msg-id 3CF77684-FA8D-4D63-AD95-DC4C9A2537E3@enterprisedb.com
Whole thread Raw
In response to Re: new heapcheck contrib module  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: new heapcheck contrib module
List pgsql-hackers

> On Oct 22, 2020, at 1:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> ooh, looks like prairiedog sees the problem too.  That means I should be
> able to reproduce it under a debugger, if you're not certain yet where
> the problem lies.

Thanks, Tom, but I question whether the regression test failures are from a problem in the verify_heapam.c code.  I
thinkthey are a busted perl test.  The test was supposed to corrupt the heap by overwriting a heap file with a large
chunkof garbage, but in fact only wrote a small amount of garbage.  The idea was to write about 2000 bytes starting at
offset32 in the page, in order to corrupt the line pointers, but owing to my incorrect use of syswrite in the perl
test,that didn't happen. 

I think the uninitialized variable warning is warning about a real problem in the c-code, but I have no reason to think
thatparticular problem is causing this particular regression test failure. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: new heapcheck contrib module
Next
From: Mark Dilger
Date:
Subject: Re: new heapcheck contrib module