Re: mylog() + qlog() implementation - Mailing list pgsql-odbc

Tom Lane wrote:
>
> Kristis Makris <kristis.makris@datasoft.com> writes:
> > -#define PG_BINARY_W                  "w"
> > +#define PG_BINARY_W                  "a"
>
> Surely this would break a lot of other uses?

Practically no. misc.c is the only place where
PG_BINARY_W is used.

> I don't object to writing logfiles in append mode... but the
> PG_BINARY_x symbols probably shouldn't be used for logfiles
> in the first place, and in any case we need to distinguish
> "write" from "append" mode.  I think a more extensive patch
> that defines suitable PG_APPEND symbols may be called for.

I would define PG_BINARY_A and change misc.c to use
PG_BINARY_A.

regards,
Hiroshi Inoue
    http://w2422.nsk.ne.jp/~inoue/