Re: Small fix for _equalValue() - Mailing list pgsql-patches

From Thomas Lockhart
Subject Re: Small fix for _equalValue()
Date
Msg-id 3C879717.4C698966@fourpalms.org
Whole thread Raw
In response to Small fix for _equalValue()  (Fernando Nasser <fnasser@redhat.com>)
List pgsql-patches
...
> Someone is using NULL strings in gram.y, like in:
>     n->args = makeList1(makeStringConst($4, NULL));
> there are several instances of it, all related to variable set.
> Well, NULL is a valid value for a (char *) so this seems legal
> enough to me.

Ah, that was me, to allow comma-delimited lists of parameters to be sent
to the SET handling code. In previous versions, multi-parameter
arguments had to be enclosed in quotes. For most of the SET variables,
lists aren't indicated, but I wanted to use the list for all cases to
minimize the special cases downstream.

If this should be done differently I'm happy for suggestions...

                    - Thomas

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Small fix for _equalValue()
Next
From: Thomas Lockhart
Date:
Subject: Re: Small fix for _equalValue()