Re: CI: Add task that runs pgindent - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: CI: Add task that runs pgindent
Date
Msg-id 3AFFBE95-BC6B-4A8E-9CE6-D5CA4533D690@yesql.se
Whole thread Raw
In response to Re: CI: Add task that runs pgindent  (Jelte Fennema-Nio <me@jeltef.nl>)
Responses Re: CI: Add task that runs pgindent
Re: CI: Add task that runs pgindent
List pgsql-hackers
> On 22 Oct 2025, at 11:24, Jelte Fennema-Nio <me@jeltef.nl> wrote:
>
> On Wed, 22 Oct 2025 at 10:49, Daniel Gustafsson <daniel@yesql.se> wrote:
>> Orange cross and Red cross are probably too similar to be easily discernible
>> for people with color blindness.  Since the patch is technically "green", what
>> do you think about just changing the checkmark on such patches?
>
> Good point. I changed it to an orange triangle + exclamation point now
> (see attached). And everything also seems to work as expected in the
> commitfest app prod environment, because this patch now shows as
> correctly as yellow: https://commitfest.postgresql.org/patch/6148/

I like the different shape and symbol, but I would probably keep it green to
indicate that it's informational rather than actionable.  We don't want a
flurry of patch re-submissions with only whitespace changes eating CI resources
when the previous build was successful. Just my €0,02.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tim Waizenegger
Date:
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement
Next
From: BharatDB
Date:
Subject: Re: Fix ALTER TABLE DROP EXPRESSION with inheritance hierarchy