Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date
Msg-id 3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de
Whole thread Raw
In response to Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
List pgsql-committers
Hi,

On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> Cfbot didn't catch this, because it only triggered a warning, not a failure.  We probably should add -Werror?
>
>Yeah -- nobody is going to go digging through cfbot logs for warnings,
>especially when they know that the Compiler Warnings task is supposed
>to complain about those.
>
>I don't think -Werror helps any though; it's a matter of whether the
>cfbot is paying attention to headerscheck's exit status ...

Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.