Re: [PATCH] Verify Checksums during Basebackups - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Verify Checksums during Basebackups
Date
Msg-id 3980.1522765933@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Verify Checksums during Basebackups  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Verify Checksums during Basebackups  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
I wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Unless.. %ld is the wrong thing to print:
>> static int64 total_checksum_failures;
>> We should perhaps be using something other than %ld to print that?

> INT64_FORMAT.

BTW, don't just stick INT64_FORMAT into the message-to-be-translated,
or you'll break things for translation.  Good practice is to sprintf
into a local char array with INT64_FORMAT, then include the number
into the displayed message with %s.  You can find examples easily
by grepping for INT64_FORMAT.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Verify Checksums during Basebackups
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions