Re: pgsql: Add support for basic NUMA awareness - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add support for basic NUMA awareness
Date
Msg-id 3979923.1744122992@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add support for basic NUMA awareness  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Add support for basic NUMA awareness
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I noticed this a little further up in dogfish's log:
>>
>> ninja: bad depfile: expected ':', saw 's'

> I noticed that too - but it happened even before the hard failures. Will look at it in a bit.

After catching up on the hackers thread, I wondered if this isn't
actually part of the identical issue, that is ninja is noticing
that there's not a dependency leading to that include file.

> I think part of the file would make sense to eventually use in FE code, we should move the SQL function and the page
sizefunction out.  

Works for me.  But a file in src/port/ should really use only c.h
if at all possible.  Otherwise (as Andrew said) it has to choose
one of postgres.h and postgres_fe.h depending on FRONTEND.

            regards, tom lane



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Add support for basic NUMA awareness
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Add support for basic NUMA awareness