Re: pgsql: Add support for basic NUMA awareness - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add support for basic NUMA awareness
Date
Msg-id 3976705.1744121148@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add support for basic NUMA awareness  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pgsql: Add support for basic NUMA awareness
List pgsql-committers
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas.vondra@postgresql.org> wrote:
>> Add support for basic NUMA awareness

> dogfish is a little bit upset it seems.

Hm, but why isn't anything else?

I noticed this a little further up in dogfish's log:

ninja: bad depfile: expected ':', saw 's'

I wonder if there's something a bit wrong with dogfish's meson
and/or ninja versions.

> Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
> FRONTEND guard for postgres_fe.h as well?

No, because it's evidently backend-only code.  The real question
is why is it in src/port/, because everything there gets built
for both frontend and backend.

            regards, tom lane



pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: Fix PG 17 [NOT] NULL optimization bug for domains
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Add support for basic NUMA awareness