Re: Remove pg_strtouint64(), use strtoull() directly - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove pg_strtouint64(), use strtoull() directly
Date
Msg-id 3937412.1639149917@sss.pgh.pa.us
Whole thread Raw
In response to Remove pg_strtouint64(), use strtoull() directly  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Remove pg_strtouint64(), use strtoull() directly
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Therefore, remove pg_strtouint64(), and use strtoull() directly in all 
> call sites.

Our experience with the variable size of "long" has left a sufficiently
bad taste in my mouth that I'm not enthused about adding hard-wired
assumptions that "long long" is identical to int64.  So this seems like
it's going in the wrong direction, and giving up portability that we
might want back someday.

I'd be okay with making pg_strtouint64 into a really thin wrapper
(ie a macro, at least on most platforms).  But please let's not
give up the notational distinction.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: track_io_timing default setting
Next
From: Laurenz Albe
Date:
Subject: Re: track_io_timing default setting