Re: more ALTER .. DEPENDS ON EXTENSION fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: more ALTER .. DEPENDS ON EXTENSION fixes
Date
Msg-id 3926.1583937053@sss.pgh.pa.us
Whole thread Raw
In response to Re: more ALTER .. DEPENDS ON EXTENSION fixes  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: more ALTER .. DEPENDS ON EXTENSION fixes  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: more ALTER .. DEPENDS ON EXTENSION fixes  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I'm still not sure whether to apply 0003 (+ your tab-completion patch,
> thanks for it) to backbranches or just to master.  It seems legitimate
> to see it as a feature addition, but OTOH the overall feature is not
> complete without it ...

0003 is the command addition to allow removing such a dependency,
right?  Given the lack of field demand I see no reason to risk
adding it to the back branches.

BTW, I did not like the syntax too much.  "NO DEPENDS ON EXTENSION"
doesn't seem like good English.  "NOT DEPENDS ON EXTENSION" is hardly
any better.  The real problem with both is that an ALTER action should
be, well, an action.  A grammar stickler would say that it should be
"ALTER thing DROP DEPENDENCY ON EXTENSION ext", but perhaps we could
get away with "ALTER thing DROP DEPENDS ON EXTENSION ext" to avoid
adding a new keyword.  By that logic the original command should have
been "ALTER thing ADD DEPENDS ON EXTENSION ext", but I suppose it's
too late for that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Additional improvements to extended statistics
Next
From: Tom Lane
Date:
Subject: Re: SERIAL datatype column skipping values.