Re: Cygwin PostgreSQL CVS Patch - Mailing list pgsql-ports

From Tom Lane
Subject Re: Cygwin PostgreSQL CVS Patch
Date
Msg-id 3924.979840998@sss.pgh.pa.us
Whole thread Raw
In response to Re: Cygwin PostgreSQL CVS Patch  (Jason Tishler <Jason.Tishler@dothill.com>)
Responses Re: Cygwin PostgreSQL CVS Patch
List pgsql-ports
Jason Tishler <Jason.Tishler@dothill.com> writes:
> 1. Add the following cruft right before the above:

> #ifdef __CYGWIN__
> #include <cygwin/version.h>
> #endif

> 2. Move the including of os.h to somewhere before the above.

I don't like #2 since there may be (now or in the future) port header
files that depend on being able to override config.h choices.

A third alternative is to remove all mention of cygwin from the
test in config.h, allowing it to #define HAVE_UNIX_SOCKETS always,
and then in the cygwin os.h #undef it again if it's old cygwin.

            regards, tom lane

pgsql-ports by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cygwin PostgreSQL Regression Test Problems
Next
From: Tom Lane
Date:
Subject: Re: Cygwin PostgreSQL Regression Test Problems