Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Date
Msg-id 3919002.1595048601@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> On Sat, Jul 11, 2020 at 11:53 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Pushed with some fiddling.  Mainly, if we're going to the trouble of
>> checking for binary mode here, we might as well skip allocating the
>> line_buf too.

> Isn't it good if we backpatch this to versions 13, 12, 11 and so on?

Given the lack of complaints, I wasn't excited about it.  Transient
consumption of 64K is not a huge deal these days.  (And yes, I've
worked on machines where that was the entire address space.  But that
was a very long time ago.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Next
From: John Naylor
Date:
Subject: Re: factorial function/phase out postfix operators?