Re: Add "format" target to make and ninja to run pgindent and pgperltidy - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Date
Msg-id 3915955.1767196446@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add "format" target to make and ninja to run pgindent and pgperltidy  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Add "format" target to make and ninja to run pgindent and pgperltidy
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2025-12-31 We 10:26 AM, Tom Lane wrote:
>> On the substance of the patch: I wonder whether we could make things
>> more reliable by using git metadata to figure out which .h and .c
>> files to point pgindent at.

> I guess what you're wanting is a test to see if the file is in git or a 
> generated file? That doesn't really arise for me as I always do vpath 
> builds, so generated files are always elsewhere.

Right.  But if we're trying to make this easy, we need to make
the automation work for all three use-cases (in-tree makefiles,
vpath makefiles, meson).  I was just wondering if relying on
git would simplify getting the same results in all three.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Next
From: Andrew Dunstan
Date:
Subject: Re: Can we remove support for standard_conforming_strings = off yet?