Re: Suggestion to add --continue-client-on-abort option to pgbench - Mailing list pgsql-hackers

> On Nov 13, 2025, at 11:47, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Nov 13, 2025 at 11:21 AM Chao Li <li.evan.chao@gmail.com> wrote:
>> I debugged further this morning, and I think I have found the root cause. Ultimately, the problem is not with
discardUntilSync(),instead, discardAvailableResults() mistakenly eats PGRES_PIPELINE_SYNC. 
>
> Thanks for debugging!
>
> Yes, discardAvailableResults() can discard PGRES_PIPELINE_SYNC,
> but do you mean that's the root cause of the assertion failure
> Nagata-san reported?
> Since that failure can occur even in older branches, I was thinking
> that newer code
> like discardAvailableResults() in master isn't the root cause...
>

I haven’t debugged with old code, but the old code also discard non-NULL results:

```
- do
- {
- res = PQgetResult(st->con);
- PQclear(res);
- } while (res);
+ discardAvailableResults(st);
```

Which may also discard the sync message. That’s my guess. I can also debug the old code this afternoon.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/