Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals
Date
Msg-id 3907973.1675958156@sss.pgh.pa.us
Whole thread Raw
In response to Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals
Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals
List pgsql-hackers
Richard Guo <guofenglinux@gmail.com> writes:
> It seems to me there is oversight here.  Actually in next level up this
> othersj would null all the relids in its syn_righthand, not only the
> relids in its min_righthand.

Good point.  I think this code originated before it was clear to me
that nullingrels would need to follow the syntactic structure.

> This query would trigger the Assert() in search_indexed_tlist_for_var.
> So I wonder that we should use othersj->syn_righthand here.

There are two such calls in deconstruct_distribute_oj_quals ...
don't they both need this change?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: ICU locale validation / canonicalization
Next
From: Robert Haas
Date:
Subject: Re: Weird failure with latches in curculio on v15