Re: pgsql: Cache by-reference missing values in a long lived context - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Cache by-reference missing values in a long lived context
Date
Msg-id 3907902.1692890821@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Cache by-reference missing values in a long lived context  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Cache by-reference missing values in a long lived context
List pgsql-committers
Andrew Dunstan <andrew@dunslane.net> writes:
> Cache by-reference missing values in a long lived context

The v11 version of this patch is causing a compiler warning for me:

In file included from heaptuple.c:58:
heaptuple.c: In function 'missing_hash':
heaptuple.c:97:3: warning: implicit declaration of function 'hash_any'; did you mean 'hash_stats'?
[-Wimplicit-function-declaration]
   hash_any((const unsigned char *) entry->value, entry->len));
   ^~~~~~~~
../../../../src/include/postgres.h:471:38: note: in definition of macro 'DatumGetUInt32'
 #define DatumGetUInt32(X) ((uint32) (X))
                                      ^

It seems to work anyway, but please fix.

            regards, tom lane



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Add test for inherited CHECK constraint drop
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid unnecessary plancache revalidation of utility statements.