Is pg_dump still broken? - Mailing list pgsql-hackers

From Mike Mascari
Subject Is pg_dump still broken?
Date
Msg-id 3883B101.E0593FE7@mascari.com
Whole thread Raw
Responses Re: [HACKERS] Is pg_dump still broken?
List pgsql-hackers
On Sunday, I downloaded the newest snapshot of pg_dump, with Tom's fixes
applied (it no longer dumps core when dumping indexes). However, pg_dump
is incorrectly dumping argument lists for trigger procedures:

test=# drop trigger mytrigger on mytable;
DROP
test=# create trigger mytrigger
before insert on mytable
for each row execute procedure autoinc ('myfield', 'myseq');
CREATE

[postgres@ferrari /tmp]$ pg_dump test
...
CREATE TRIGGER "mytrigger" BEFORE INSERT ON "mytable" FOR EACH ROW
EXECUTE PROCEDURE autoinc ('myfield', 'myfieldmyseq');
...

Note the second parameter to autoinc() -- it should be 'myseq', not
'myfieldmyseq'. I suspect someone isn't doing a resetPQExpBuffer()
somewhere. Can anyone confirm this?

Mike Mascari





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] How to ignore system indexes
Next
From: "Hiroshi Inoue"
Date:
Subject: RE: [HACKERS] How to ignore system indexes