Re: Protocol forced to V2 in low-memory conditions? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Protocol forced to V2 in low-memory conditions?
Date
Msg-id 3880.1378783799@sss.pgh.pa.us
Whole thread Raw
In response to Protocol forced to V2 in low-memory conditions?  (Maciek Sakrejda <m.sakrejda@gmail.com>)
Responses Re: Protocol forced to V2 in low-memory conditions?
List pgsql-hackers
Maciek Sakrejda <m.sakrejda@gmail.com> writes:
> One of our customers seems to be running into exactly the issue
> hypothesized about by Tom here:
> http://www.postgresql.org/message-id/8040.1314403175@sss.pgh.pa.us
> Was the possibility of an inadvertent protocol downgrade addressed as part
> of that patch? I read through the thread, but it wasn't entirely clear.

No, a quick look at report_fork_failure_to_client shows it still always
sends V2 protocol.  We fixed some of the lesser issues discussed in that
thread, but I don't think we ever agreed how to deal with this one.

I've been thinking of late that it might be time to retire libpq's
support for V2 protocol (other than in the specific context of the first
error message received while trying to make a connection).  If we did
that, we'd remove the code path that thinks it should downgrade to V2
protocol, and thus fix this problem by removing code not adding more.

However, that doesn't sound like a back-patchable solution, and also
it remains unclear whether non-libpq clients such as JDBC have an issue
with this.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: psql: small patch to correct filename formatting error in '\s FILE' output