Re: [PATCHES] createdb/dropdb fixes - Mailing list pgsql-hackers

From Thomas Lockhart
Subject Re: [PATCHES] createdb/dropdb fixes
Date
Msg-id 3856526F.F0742344@alumni.caltech.edu
Whole thread Raw
Responses Re: [HACKERS] Re: [PATCHES] createdb/dropdb fixes
Re: [PATCHES] createdb/dropdb fixes
List pgsql-hackers
> All I really wanted to do is fix TODO item
> * database names with spaces fail
> but that is already taken care of, they work fine. Please check it off.
> Meanwhile, database names with single quotes in names don't work very well
> at all, and because of shell quoting rules this can't be fixed, so I put
> in error messages to that end.

That seems to be a bit heavy handed; why bother disallowing things in
the backend because some (small number of) shell-based tools have
trouble as clients? I'd prefer filtering that at the client end, and
allowing capable clients to do whatever they please.

There is a related issue which afaik no one has addressed yet: the
permissions ACLs are stored as a string with a format like
"accountname=permissions" (doing this from memory, so the details may
be wrong) but with quoting allowed for table names and user names one
could embed an equals sign into an account or group name and muck with
permissions. I haven't looked at the code in a long time, but was
thinking about recoding ACLs as a two-field type to enforce an
unambigous interpretation of the two fields. Interested??
                       - Thomas

-- 
Thomas Lockhart                lockhart@alumni.caltech.edu
South Pasadena, California


pgsql-hackers by date:

Previous
From: Zeugswetter Andreas SB
Date:
Subject: AW: [HACKERS] Create Group
Next
From: Thomas Lockhart
Date:
Subject: Re: [HACKERS] libpq questions...when threads collide