Re: Extracting cross-version-upgrade knowledge from buildfarm client - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Extracting cross-version-upgrade knowledge from buildfarm client
Date
Msg-id 3808228.1674076461@sss.pgh.pa.us
Whole thread Raw
In response to Re: Extracting cross-version-upgrade knowledge from buildfarm client  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Extracting cross-version-upgrade knowledge from buildfarm client
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-01-18 We 14:32, Tom Lane wrote:
>> I suppose that the reason for not running under $from_source is to
>> avoid corrupting the saved installations with unofficial versions.
>> However, couldn't we skip the "save" step and still run the upgrade
>> tests against whatever we have saved?  (Maybe skip the same-version
>> test, as it's not quite reflecting any real case then.)

> Something like this should do it:
> my $source_tree = $from_source || "$self->{buildroot}/$this_branch/pgsql";

Ah, I didn't understand that $from_source is a path not just a bool.

What do you think about the above questions?  Is this $from_source
exclusion for the reason I guessed, or some other one?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: almost-super-user problems that we haven't fixed yet
Next
From: Bruce Momjian
Date:
Subject: Re: document the need to analyze partitioned tables