Re: [PORTS] Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc - Mailing list pgsql-ports

From Uncle George
Subject Re: [PORTS] Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Date
Msg-id 38007AA5.FCDCA567@voicenet.com
Whole thread Raw
In response to Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-ports
egcs, also defines both __alpha & __alpha__
( if u havent't test there already ) I believe this covers all avail compiled
on the Digital Alpha  box
gat
Tom Lane wrote:

> "Pedro J. Lobo" <pjlobo@euitt.upm.es> writes:
> > Someone has changed the "#if defined(__alpha)" tests that existed in
> > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
> > is that DEC (¿Compaq?) C only defines __alpha, (gcc defines both __alpha
> > and __alpha__) so it doesn't work anymore.
>
> I thought that was bogus when it was done.  Should be
>         #if defined(__alpha) || defined(__alpha__)
> to cover both compilers.
>
> > In fact, there are two places where the test is used, one inside a "#if
> > defined(__GNUC__)" and the other one inside the corresponding "#else". It
> > seems that the easiest sollution is to change the check inside the "#else"
> > back to "#if defined(__alpha)".
>
> ... which would break whichever compiler is being used by the person who
> submitted the patch.  I don't think it was changed on a whim.
>
>                         regards, tom lane
>
> ************


pgsql-ports by date:

Previous
From: Peter Schaefer
Date:
Subject: 'current'::datetime
Next
From: Brian Edmonds
Date:
Subject: Linux 2.2.12 SMP build success report