Re: Docbook toolchain interfering with patch review? - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: Docbook toolchain interfering with patch review?
Date
Msg-id 37ed240d0907161707q1dcd348cjc99b8ee8c9616009@mail.gmail.com
Whole thread Raw
In response to Docbook toolchain interfering with patch review?  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Docbook toolchain interfering with patch review?
Re: Docbook toolchain interfering with patch review?
List pgsql-hackers
2009/7/17 Josh Berkus <josh@agliodbs.com>:
> This seems like a serious issue for development.  Reviewers, how many of you
> are able to build docs with each patch?

Being able to build docs did require some fidgeting with the docbook
packages (on Gentoo).  The only trick was working out exactly which
packages I needed to install.  Since getting past that, I've not had
any problems building the docs.  Although it is pretty slow.

As Merlin and Andrew have noted, being able to build the docs is a
nice-to-have for documentation review, not a genuine requirement.  You
*can* review changes to SGML right there in the diff.  Especially if
the changes are not extensive and/or don't alter the structure of the
document.

Cheers,
BJ


pgsql-hackers by date:

Previous
From: Brendan Jurd
Date:
Subject: Re: WIP: generalized index constraints
Next
From: KaiGai Kohei
Date:
Subject: Re: [PATCH] [v8.5] Security checks on largeobjects