Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp) - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)
Date
Msg-id 37ed240d0901262025h1d60b08asbfdedca67689d0d6@mail.gmail.com
Whole thread Raw
In response to Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)  (Brendan Jurd <direvus@gmail.com>)
List pgsql-hackers
On Tue, Jan 27, 2009 at 3:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Brendan Jurd <direvus@gmail.com> writes:
>> A quick grep through the backend code shows that strlcpy and strncpy
>> are both in use, with neither having a clear majority.  I used strncpy
>> because it is more prevalent within src/backend/utils/adt.
>
> strncpy is generally deprecated; any remaining uses you find of it
> are probably only there for lack of round tuits.  Use strlcpy in new
> code, unless there's a pretty strong argument that strncpy is actually
> clearer for a given usage.
>

Thanks for clearing that up Tom.  I will update the patch to use
strlcpy shortly.

Cheers,
BJ


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: 8.4 release planning
Next
From: Tom Lane
Date:
Subject: Re: 8.4 release planning