Re: TODO <-> Commitfest - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: TODO <-> Commitfest
Date
Msg-id 37ed240d0808280939y1474e8b9vaecd9706561805a3@mail.gmail.com
Whole thread Raw
In response to Re: TODO <-> Commitfest  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Aug 28, 2008 at 3:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alternatively, suggest that the email message submitting the patch
> mentions that "this resolves TODO item so-and-so".  Then the committer
> would know to go fix the TODO item.
>

Yes, I've noticed that some submitters are already doing this, and it
seems to work.  Although I do wonder about patch threads where the
initial patch kicks off further discussion, and several revisions of
the patch ensue.  Is the committer expected to recall that the very
first post contained a reference to a TODO item when committing the
final version?

Anyway, I think it would be worth adding this guidance to
http://wiki.postgresql.org/wiki/Submitting_a_Patch and perhaps also
http://wiki.postgresql.org/wiki/Developer_FAQ#I_have_developed_a_patch.2C_what_next.3F

I'll go do this now.  Feel free to edit/revert/whatever my changes if
you don't like them =)

Cheers,
BJ


pgsql-hackers by date:

Previous
From: Grant Finnemore
Date:
Subject: Re: Proposal to sync SET ROLE and pg_stat_activity
Next
From: Tom Lane
Date:
Subject: WIP patch: add parser location info to most expression node types