Re: BUG #2072: CPPFLAGS clobbered - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #2072: CPPFLAGS clobbered
Date
Msg-id 3768.1133023171@sss.pgh.pa.us
Whole thread Raw
In response to BUG #2072: CPPFLAGS clobbered  ("Keith Randall" <randallk@gmail.com>)
List pgsql-bugs
"Keith Randall" <randallk@gmail.com> writes:
> In src/template/linux the
> CPPFLAGS="-D_GNU_SOURCE"
> overrides command-line CPPFLAGS
> I change it to
> CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
> and am back in business.

That's pretty much entirely the wrong way to fix it; or at least it's
inconsistent with the way we handle CFLAGS etc, and doing it this way
would require touching every template not only linux.

I'm thinking that configure.in should handle template CPPFLAGS settings
the same way it handles CFLAGS, ie, command line settings override the
template.  Probably LDFLAGS too.

BTW, why do you feel a need to override CPPFLAGS in the first place?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #2071: ERROR: invalid multibyte character for locale
Next
From: Bruce Momjian
Date:
Subject: Re: Patch to allow contrib/pgbench files to have blank lines