Re: FindDefinedSymbol() is subtly broken - Mailing list pgsql-hackers

From Tom Lane
Subject Re: FindDefinedSymbol() is subtly broken
Date
Msg-id 3761.1526760348@sss.pgh.pa.us
Whole thread Raw
In response to FindDefinedSymbol() is subtly broken  (John Naylor <jcnaylor@gmail.com>)
List pgsql-hackers
John Naylor <jcnaylor@gmail.com> writes:
> Long story short: It expects an array of paths, but will die if it
> can't find the symbol in the first path. Arguably it's a bug, but
> since the original use case for multiple paths is long gone anyway, it
> might never occur in practice. The attached patch changes it to expect
> a single path.

> Also attached: a few minor build script cleanups I've noticed along the way:
> -more accurate error message
> -s/print sprintf/printf/
> -a recent perltidy change made a couple multi-line strings look odd,
> so use heredocs (which other scripts use in this case anyway)
> -make generated file footers match project style
> -remove a duplicate comment

This all seemed like minor cleanup from v11 changes, so I went
ahead and pushed it rather than waiting for v12.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: printf format selection vs. reality
Next
From: Tom Lane
Date:
Subject: printf("%lf",...) isn't actually portable