Re: New instability in stats regression test - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New instability in stats regression test
Date
Msg-id 3750168.1701056099@sss.pgh.pa.us
Whole thread Raw
In response to Re: New instability in stats regression test  (Michael Paquier <michael@paquier.xyz>)
Responses Re: New instability in stats regression test
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> With all that in mind and because we have checks for the individual
> targets with pg_stat_reset_shared(), I would agree to just remove it
> entirely.  Say as of the attached?

I'm good with that answer --- I doubt that this test sequence is
proving anything that's worth the cycles it takes.  If it'd catch
oversights like failing to add new stats types to the "reset all"
code path, then I'd be for keeping it; but I don't see how the
test could notice that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] fix race condition in libpq (related to ssl connections)
Next
From: Bowen Shi
Date:
Subject: Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.