Re: question about `static inline` functions in header files - Mailing list pgsql-hackers

From Tom Lane
Subject Re: question about `static inline` functions in header files
Date
Msg-id 374910.1658459023@sss.pgh.pa.us
Whole thread Raw
In response to question about `static inline` functions in header files  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: question about `static inline` functions in header files
List pgsql-hackers
Junwang Zhao <zhjwpku@gmail.com> writes:
> I notice that there are lots of *static inline functions* in header files,
> the header file's content will go into each translation unit at preprocess
> phase, that means all the c file including the header will have a copy
> of the static inline function.

We are assuming that the compiler will not emit unused static functions.
This has been default behavior in gcc for ages.  If you're unfortunate
enough to have a compiler that won't do it, yes you're going to have a
bloated binary.

> IMHO, the header files should only include the inline function's declaration,
> and the definition should be in c files.

Then it couldn't be inlined, defeating the purpose.

            regards, tom lane



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: some aspects of our qsort might not be ideal
Next
From: Fujii Masao
Date:
Subject: Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().