Re: Built-in CTYPE provider - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Built-in CTYPE provider
Date
Msg-id 3744671.1710820981@sss.pgh.pa.us
Whole thread Raw
In response to Re: Built-in CTYPE provider  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> On Tue, Mar 19, 2024 at 11:55 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> This is causing all CI jobs to fail the "compiler warnings" check.

>>> I did run CI before checkin, and it passed:

> Maybe I misunderstood this exchange but ...

> Currently Windows warnings don't make any CI tasks fail ie turn red,
> which is why Jeff's run is all green in his personal github repo.
> ...
> But I did teach cfbot to do some extra digging through the logs,

Ah.  What I should have said was "it's causing cfbot to complain
about every patch".

Seems like the divergence in the pass criterion is not such a
great idea.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Built-in CTYPE provider
Next
From: Himanshu Upadhyaya
Date:
Subject: Re: remaining sql/json patches