Re: Avoid needless copy in nodeMaterial - Mailing list pgsql-patches

From Tom Lane
Subject Re: Avoid needless copy in nodeMaterial
Date
Msg-id 3744.1192509252@sss.pgh.pa.us
Whole thread Raw
In response to Avoid needless copy in nodeMaterial  (Neil Conway <neilc@samurai.com>)
Responses Re: Avoid needless copy in nodeMaterial  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> Attached is a patch that avoids a needless copy of the result tuple in
> nodeMaterial, in the case that we don't have a previously-materialized
> tuple to return.

Seems like this needs more comments about what's happening, rather
than less ...

Also, it looks to me like the plan node's own resultslot might never be
assigned to at all, when the subplan returns zero rows.  Does this
corner case still work correctly?

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Avoid needless copy in nodeMaterial
Next
From: Neil Conway
Date:
Subject: Re: Avoid needless copy in nodeMaterial