Re: pgsql: Use SIGURG rather than SIGUSR1 for latches. - Mailing list pgsql-committers

Thomas Munro <tmunro@postgresql.org> writes:
> Use SIGURG rather than SIGUSR1 for latches.

I notice that postmaster.c still does

#ifdef SIGURG
    pqsignal_pm(SIGURG, SIG_IGN);          /* ignored */
#endif

It appears to me that this should now read

    pqsignal_pm(SIGURG, dummy_handler);    /* unused, reserve for children */

for the reasons explained in the comment for dummy_handler.

It's possible that that argument doesn't apply to the way SIGURG is used
in this patch, but I don't see a good reason to ignore the convention of
setting up the handler this way.

            regards, tom lane