Re: Check for tuplestorestate nullness before dereferencing - Mailing list pgsql-hackers

From Nikolay Shaplov
Subject Re: Check for tuplestorestate nullness before dereferencing
Date
Msg-id 3739806.bqPgKRP4r2@thinkpad-pgpro
Whole thread Raw
In response to Re: Check for tuplestorestate nullness before dereferencing  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Check for tuplestorestate nullness before dereferencing
List pgsql-hackers
В письме от пятница, 18 октября 2024 г. 02:28:22 MSK пользователь David Rowley
написал:

> It would be good to know if the optimisation added in d2c555ee5 ever
> applies with today's code. If it does apply, we should likely add a
> test case for it and if it never does, then we should just remove the
> optimisation and always create the tuplestore when it's NULL.

That's sounds reasonable. It looks like that removing "node->eflags != 0" check
is more logical then adding not null check.

> If it does apply, we should likely add a test case for it

Do you have any idea how to test it?


--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: index prefetching
Next
From: jian he
Date:
Subject: disallow alter individual column if partition key contains wholerow reference