Re: pgsql: Add pg_stat_archiver statistics view. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add pg_stat_archiver statistics view.
Date
Msg-id 3720.1390940892@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Add pg_stat_archiver statistics view.  (Fujii Masao <fujii@postgresql.org>)
Responses Re: pgsql: Add pg_stat_archiver statistics view.
List pgsql-committers
Fujii Masao <fujii@postgresql.org> writes:
> Add pg_stat_archiver statistics view.
> This view shows the statistics about the WAL archiver process's activity.

For the record, this commit should certainly have included a catversion.h
bump.

Usually it's the committer's responsibility to add that when necessary;
we don't ask people to include it in submitted patches because they'd
inevitably get patch conflicts depending on what order things get
committed in.

There are a couple of rules of thumb about when to increase catversion:

* system catalog contents no longer consistent with backend executable
(in this case, pg_proc.h versus the set of functions actually present)

* regression tests would not pass without a fresh initdb (rules.out
change makes that true here)

            regards, tom lane


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Add pg_stat_archiver statistics view.
Next
From: Andrew Dunstan
Date:
Subject: pgsql: New json functions.