Re: Clear base backup progress reporting on error - Mailing list pgsql-hackers

From Chao Li
Subject Re: Clear base backup progress reporting on error
Date
Msg-id 370AB27A-3905-455F-A3FB-7F24854D33AE@gmail.com
Whole thread
Responses Re: Clear base backup progress reporting on error
List pgsql-hackers

> On Jun 26, 2026, at 18:46, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Jun 26, 2026 at 5:59 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> This patch makes the following changes:
>
> Thanks for the report and patch!
>
>> I don’t think this is a serious bug, because with the usual pg_basebackup command path, the client normally
disconnectsafter the error, so the stale progress entry is not observable. It is mainly visible when the same
replicationconnection stays open after the failed BASE_BACKUP command. So I feel it might not be worth adding a TAP
test.
>
> +1
>
> You may think this isn't worth backpatching to the stable branches
> for the same reason?
>

I personally don’t feel back-patch is needed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: [BUG] ECPG crash with union type
Next
From: Henson Choi
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks