Re: Block-level CRC checks - Mailing list pgsql-hackers

From Jonah H. Harris
Subject Re: Block-level CRC checks
Date
Msg-id 36e682920810021104t32a3ff3by1d616961272d1c46@mail.gmail.com
Whole thread Raw
In response to Re: Block-level CRC checks  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Block-level CRC checks
List pgsql-hackers
On Thu, Oct 2, 2008 at 1:44 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> How about when a hint bit is set and the page is not already dirty, set
> the checksum to the "always valid" value?  The problem I have with this
> idea is that there would be lots of pages excluded from the CRC checks,
> a non-trivial percentage of the time.

I don't like that because it trades-off corruption detection (the
whole point of this feature) for a slight performance improvement.

> Maybe we could mix this with Simon's approach to counting hint bit
> setting, and calculate a valid CRC on the page every n-th non-logged
> change.

I still think we should only calculate checksums on the actual write.
And, this still seems to have an issue with WAL, unless Simon's
original idea somehow included recording hint bit settings/dirtying
the page in WAL.

-- 
Jonah H. Harris, Senior DBA
myYearbook.com


pgsql-hackers by date:

Previous
From: "Jonah H. Harris"
Date:
Subject: Re: Block-level CRC checks
Next
From: Aidan Van Dyk
Date:
Subject: Re: Block-level CRC checks