Re: [HACKERS] Including Snapshot Info with Indexes - Mailing list pgsql-patches

From Jonah H. Harris
Subject Re: [HACKERS] Including Snapshot Info with Indexes
Date
Msg-id 36e682920801230919u64ef55e4i68814fd09f38c20f@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Including Snapshot Info with Indexes  ("Gokulakannan Somasundaram" <gokul007@gmail.com>)
Responses Re: [HACKERS] Including Snapshot Info with Indexes
List pgsql-patches
On Jan 23, 2008 11:28 AM, Gokulakannan Somasundaram <gokul007@gmail.com> wrote:
> Fixed a type 'o'....

I'm playing with this now against 8.3 HEAD.  Looks like there's a
couple things which are problematic:

- DefineIndex was updated only in bootparse.c, not in bootparse.y
- The patch contains changes to pg_config.h
- THICK isn't defined in gram.y (as a token or under
unreserved_keywords), so compilation of keywords.c fails.

In the future, please make changes to the proper pre-built files so
that someone doesn't have to configure it, then patch it.  I have them
fixed and will submit the patch back here if you'd like.  Or, you can
fix it.  It's up to you :)

--
Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324
EnterpriseDB Corporation                | fax: 732.331.1301
499 Thornall Street, 2nd Floor          | jonah.harris@enterprisedb.com
Edison, NJ 08837                        | http://www.enterprisedb.com/

pgsql-patches by date:

Previous
From: "Gokulakannan Somasundaram"
Date:
Subject: Re: [HACKERS] Including Snapshot Info with Indexes
Next
From: Magnus Hagander
Date:
Subject: Re: Compile of Test example is put into win32.mak of libpq.