Re: BUG #16112: large, unexpected memory consumption - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #16112: large, unexpected memory consumption
Date
Msg-id 368.1573665707@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #16112: large, unexpected memory consumption  (Andres Freund <andres@anarazel.de>)
Responses Re: BUG #16112: large, unexpected memory consumption
List pgsql-bugs
Andres Freund <andres@anarazel.de> writes:
> On 2019-11-13 15:50:04 +0100, Tomas Vondra wrote:
>> The attached trivial patch fixes that by adding a pfree() at the end of
>> the function.

> Hm. That's clearly an improvement. But I'm not quite sure it's really
> the right direction. It seems like a bad idea to rely on
> ExecMakeTableFunctionResult() otherwise never leaking any memory.

Considering that ExecMakeTableFunctionResult went from zero pallocs
to one, I don't see a strong reason why it should have bothered with
a private memory context before, nor do I think that's a good
response now.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUG] Uninitializaed configOut.leafType used.
Next
From: Tomas Vondra
Date:
Subject: Re: BUG #16112: large, unexpected memory consumption