Re: Odd usage of errmsg_internal in bufmgr.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Odd usage of errmsg_internal in bufmgr.c
Date
Msg-id 364835.1770929067@sss.pgh.pa.us
Whole thread Raw
In response to Re: Odd usage of errmsg_internal in bufmgr.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I apparently may be alone in this, but I find 6 repetitions of ereports, with
> differently indented messages and arguments, depending on whether it's an
> errmsg, errdetails, errhint way harder to scan and modify than something that
> just shows the different messages with consistent indentation.

I was about to make a similar comment: I don't find anything
particularly attractive about the output that this code is trying
to generate, nor does it seem helpful to have several variations
of what's fundamentally the same message.

I'd rip it all out in favor of a generic message that covers both
the single- and multi-page cases.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Changing shared_buffers without restart
Next
From: Bruce Momjian
Date:
Subject: Re: AIX support