Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
Date
Msg-id 3631624.1731078404@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid  (Dilip Kumar <dilipbalaut@gmail.com>)
List pgsql-hackers
Dilip Kumar <dilipbalaut@gmail.com> writes:
> IIRC, In catalog we intentionally left it as Oid because RelFileNumber is
> an internal typedef bug, it is not an exposed datatype, so probably we can
> not use it in catalog.

We could declare it as RelFileNumber so that that is what C code sees,
and teach Catalog.pm to translate that to OID in the emitted catalog
contents.  I think you'd have to do that to avoid a ton of false
positives when you make RelFileNumber into a struct, and we might as
well keep the result.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: DROP VIEW name WITHOUT TYPE
Next
From: Tom Lane
Date:
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails