Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Date
Msg-id 3621151.1731977409@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
List pgsql-hackers
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
>> That's against our usual convention.

> Good catch. I've updated the patch accordingly.

Probably out of scope for this particular patch, but it occurred to me
to grep for other similar violations, and I found three:

src/bin/pg_combinebackup/copy_file.h:#include "c.h"
src/include/fe_utils/option_utils.h:#include "postgres_fe.h"
src/include/fe_utils/query_utils.h:#include "postgres_fe.h"

            regards, tom lane



pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Statistics Import and Export
Next
From: Tom Lane
Date:
Subject: Re: Making error message more user-friendly with spaces in a URI