Re: generic pseudotype IO functions? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: generic pseudotype IO functions?
Date
Msg-id 3616.1389022146@sss.pgh.pa.us
Whole thread Raw
In response to generic pseudotype IO functions?  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: generic pseudotype IO functions?
Re: generic pseudotype IO functions?
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> Does anybody have an opinion about introducing generic pseudotype IO
> functions?

Yes: -1.

> Pseudotype.c/pg_proc.h are slowly growing a number of pretty
> useless/redundant copy&pasted functions... Most for cases that are
> pretty damn unlikely to be hit by users not knowing what they do.

That's hardly the largest cost associated with inventing a new pseudotype.
Nor are there lots of new pseudotypes coming down the pike, anyway.

> What about adding a pseudotype_in/out that just error out with a generic
> message?

This will break some of the function sanity checks in opr_sanity,
I believe.  Yeah, we could lobotomize that, but I don't see any benefit.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: dynamic shared memory and locks
Next
From: Andres Freund
Date:
Subject: Re: generic pseudotype IO functions?