Re: Modern SHA2- based password hashes for pgcrypto - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Modern SHA2- based password hashes for pgcrypto
Date
Msg-id 3601727.1744049815@sss.pgh.pa.us
Whole thread Raw
In response to Re: Modern SHA2- based password hashes for pgcrypto  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> Bernd Helmle <mailings@oopsware.de> writes:
>> Here is a patch that tries to address all these issues (including
>> Andres' report). I've adjusted the error message and use ereport(), so
>> it might be more useful if we deal with not just single byte letters.

> I'd like to get mamba back to green, so I'll take care of this

And done.  FYI, we actually have a standard practice for error
messages that want to complain about a single character without
assuming it's a single-byte character:

                ereport(ERROR,
                        errcode(ERRCODE_INVALID_PARAMETER_VALUE),
                        errmsg("invalid character in salt string: \"%.*s\"",
                               pg_mblen(ep), ep));

            regards, tom lane



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Modern SHA2- based password hashes for pgcrypto
Next
From: Tom Lane
Date:
Subject: Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints