Re: [HACKERS] Macro From Hell - Mailing list pgsql-hackers

From David Hartwig
Subject Re: [HACKERS] Macro From Hell
Date
Msg-id 35F54416.4843DB75@insightdist.com
Whole thread Raw
In response to Re: [HACKERS] Macro From Hell  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers

Thomas G. Lockhart wrote:

> > > ((attr[i]->attlen) < sizeof(int32)) ? ( ((attr[i]->attlen) == -1
> > > ) ? ( ((attr[i]->attalign) == 'd') ? (((long)(ptr) + (sizeof
> > > (double) -
> > > 1)) & ~(sizeof (double) -1)) : (((long)(ptr) + (sizeof (int)
> > >  - 1)) & ~(sizeof (int) -1)) ) : ( ((attr[i]->attlen) ==
> > > sizeof(char)) ?
> > > ( (ptr) ) : ( (void)((char) 1), (((long)(ptr) + (sizeof (sh
>       ^^^^^ should perhaps be (long)(ptr)
> > > ort) - 1)) & ~(sizeof (short) - 1)) ) ) ) : ( ((attr[i]->attlen) ==
> > > sizeof(int32)) ? ( (((long)(ptr) + (sizeof (int) - 1)) & ~(sizeo
> > > f (int) -1)) ) : ( (void)((char) 1), ((attr[i]->attalign) == 'd') ?
> > > (((long)(ptr) + (sizeof (double) - 1)) & ~(sizeof (double) -1))
> > > : (((long)(ptr) + (sizeof (long) - 1)) & ~(sizeof (long) -1)) ) ) );
> > > a - 1506-226 (S) The ":" operator is not allowed between "char*" and
> > > "unsigned long".
> > Looks like I am going to have to do another DISABLE_COMPLEX_MACROS
> > entry for that new macro, just like heap_getattr().
>
> The error message indicates that the AIX compiler is complaining about a
> type mismatch within the macro, not the length of the macro itself. Try
> adding that additional coersion and see if it helps. The macro is just a
> bit "thick" (OK, _really_ thick :), so there may be another place in
> there provoking the complaint...
>

That is correct.   I was able to do several casts to get it to work this
morning.  It is hacked in for now.   Basically the problem is this:

    ptr  =  (test) ? (espression resulting in pointer) :  (expression
resulting in long)

Our compiler does not like this.  Bruce, I can send a patch if you like.


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Macro From Hell
Next
From: David Hartwig
Date:
Subject: Re: [HACKERS] Problem with the constraints test and PRIMARY KEY on UnixWare 7.