Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Date
Msg-id 359621.1637899369@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
List pgsql-committers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Nov 24, 2021 at 8:01 PM Andres Freund <andres@anarazel.de> wrote:
>> Pushed the obvious fix for that. Somehow thought I'd seen more compile failure
>> than the one WAL_DEBUG...

> Hmm, thanks. I guess i put too much trust in the compiler.

My approach to such patches is always "in grep we trust, all others
pay cash".  Even without #ifdef issues, you are highly likely to
miss comments that need to be updated.

            regards, tom lane



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Update comments